Open
Conversation
Draft
Fil
force-pushed
the
fil/brush-across-facets
branch
from
de3e623 to
6701a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plot.brush({sync: true})synchronizes the brush selection across all facets — when the user brushes in one facet, the same rectangle appears in all panes and reactive marks update across all facets.The
filterfunction's facet arguments are now optional: omittingfxorfy(or passingundefined) skips the facet check, selecting points across all values of that facet.This resolves @allisonhorst 's suggestions #2364 (comment) and #2364 (comment).
I'm keeping this as a separate PR for now (against #2360) to make the logic more apparent. Ideally if we merge this I would migrate the tests and examples to brushX on parallel time series, rather a 2D brush on penguins.
Disclaimer: I used @claude to generate the tests.